Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do not block on downstream dogweb job [backport 2.12] #10417

Merged
merged 2 commits into from
Aug 29, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Backport b5d72c1 from #10401 to 2.12.

This job is useful to run, to be able to manually check the results, but given that it fails every time and we ignore the failure in the pipeline, there is no reason to block the entire pipeline waiting for it to finish.

Checklist

  • PR author has checked that all the criteria below are met
  • The PR description includes an overview of the change
  • The PR description articulates the motivation for the change
  • The change includes tests OR the PR description describes a testing strategy
  • The PR description notes risks associated with the change, if any
  • Newly-added code is easy to change
  • The change follows the library release note guidelines
  • The change includes or references documentation updates if necessary
  • Backport labels are set (if applicable)

Reviewer Checklist

  • Reviewer has checked that all the criteria below are met
  • Title is accurate
  • All changes are related to the pull request's stated goal
  • Avoids breaking API changes
  • Testing strategy adequately addresses listed risks
  • Newly-added code is easy to change
  • Release note makes sense to a user of the library
  • If necessary, author has acknowledged and discussed the performance implications of this PR as reported in the benchmarks PR comment
  • Backport labels are set in a manner that is consistent with the release branch maintenance policy

This job is useful to run, to be able to manually check the results, but
given that it fails every time and we ignore the failure in the
pipeline, there is no reason to block the entire pipeline waiting for it
to finish.

## Checklist
- [x] PR author has checked that all the criteria below are met
- The PR description includes an overview of the change
- The PR description articulates the motivation for the change
- The change includes tests OR the PR description describes a testing
strategy
- The PR description notes risks associated with the change, if any
- Newly-added code is easy to change
- The change follows the [library release note
guidelines](https://ddtrace.readthedocs.io/en/stable/releasenotes.html)
- The change includes or references documentation updates if necessary
- Backport labels are set (if
[applicable](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting))

## Reviewer Checklist
- [ ] Reviewer has checked that all the criteria below are met
- Title is accurate
- All changes are related to the pull request's stated goal
- Avoids breaking
[API](https://ddtrace.readthedocs.io/en/stable/versioning.html#interfaces)
changes
- Testing strategy adequately addresses listed risks
- Newly-added code is easy to change
- Release note makes sense to a user of the library
- If necessary, author has acknowledged and discussed the performance
implications of this PR as reported in the benchmarks PR comment
- Backport labels are set in a manner that is consistent with the
[release branch maintenance
policy](https://ddtrace.readthedocs.io/en/latest/contributing.html#backporting)

(cherry picked from commit b5d72c1)
@github-actions github-actions bot added the changelog/no-changelog A changelog entry is not required for this PR. label Aug 27, 2024
@github-actions github-actions bot requested review from a team as code owners August 27, 2024 19:40
@erikayasuda erikayasuda enabled auto-merge (squash) August 27, 2024 19:43
@pr-commenter
Copy link

pr-commenter bot commented Aug 27, 2024

Benchmarks

Benchmark execution time: 2024-08-29 10:33:13

Comparing candidate commit 69d45bf in PR branch backport-10401-to-2.12 with baseline commit 8d3373c in branch 2.12.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 353 metrics, 47 unstable metrics.

auto-merge was automatically disabled August 28, 2024 13:09

Pull request was closed

@erikayasuda erikayasuda reopened this Aug 28, 2024
@erikayasuda erikayasuda enabled auto-merge (squash) August 28, 2024 13:09
Copy link
Contributor Author

CODEOWNERS have been resolved as:

.gitlab/dogfood.yml                                                     @DataDog/python-guild @DataDog/apm-core-python

@erikayasuda erikayasuda merged commit 274ccda into 2.12 Aug 29, 2024
113 of 114 checks passed
@erikayasuda erikayasuda deleted the backport-10401-to-2.12 branch August 29, 2024 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog A changelog entry is not required for this PR.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants